PR Review: EN-433 Log collection (logarchive) parallel to sysdiagnose (#218)
Summary
The PR adds parallel log collection via pymobiledevice3’s OsTraceService.create_archive, runs it alongside sysdiagnose, merges collect_system_logs.logarchive into the sysdiagnose tarball, and uses incremental colle…
PR Review: EN-433 Log collection (logarchive) parallel to sysdiagnose (#218)
Summary
The PR adds parallel log collection via pymobiledevice3’s OsTraceService.create_archive, runs it alongside sysdiagnose, merges collect_system_logs.logarchive into the sysdiagnose tarball, and uses incremental collection with a last_log_collection_time on the device. The design (early start in trigger service, FIFO wait after download, stall detection, fast repack) is clear and the reviewer’s earlier comments are
Kua whakamutua tēnei pūranga oro.
Ka ngaro ngā pātahitanga oro tiritiri i muri i te 24 wā. Ka taea e koe te waihanga ōna ake i raro nei!
Ka waihanga i ōna pūoro AI ake
Ka waihanga i ngā kōrero ngaio mātauranga me ngā tauira AI 20+ — tino wātea, kāore e hiahiatia te whakaingoatanga.